elide icon indicating copy to clipboard operation
elide copied to clipboard

Upgrade graphql-java from 6 to 16.2

Open wcekan opened this issue 2 years ago • 2 comments

Description

Major upgrade of GraphQL Java backported to 4.x Cherry picked from 5.0.5 PR #2228 with merge conflicts fixed.

Motivation and Context

GraphQL 6 is too old. This will be the first step in getting Elide 4.x to a more recent version of GraphQL.

How Has This Been Tested?

Unit testing. Local testing.

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

wcekan avatar Aug 12 '23 19:08 wcekan

@aklish any idea about these 2 failures?

Failures: FetcherFetchTest.testFetchWithFragments:166->runComparisonTest:208->PersistentResourceFetcherTest.runComparisonTest:285->PersistentResourceFetcherTest.runComparisonTest:302->PersistentResourceFetcherTest.assertQueryEquals:192->PersistentResourceFetcherTest.assertQueryEquals:218 author.edges[0].__typename Expected: _edges__author got: AuthorEdge ; author.edges[1].__typename Expected: _edges__author got: AuthorEdge

ModelBuilderTest.testBuild:143 authorInput ==> expected: not <null>

wcekan avatar Aug 12 '23 19:08 wcekan

Overall the changes looked good to me when compared to the original PR.

The test case testFetchWithFragments which is failing in FetcherFetchTest was removed as part of the below commit and replaced with different test cases though i can not remember why.

https://github.com/yahoo/elide/commit/9bda0185f0c316cea05c245c9003c1ada5b5911a

moizarafat avatar Sep 06 '23 02:09 moizarafat