dnscache icon indicating copy to clipboard operation
dnscache copied to clipboard

add keepalive option

Open tangxinfa opened this issue 9 years ago • 5 comments

Unlike ttl, if cached item expired by keepalive, it return the cached value, and make asynchronously dns request for update the cache.

tangxinfa avatar Nov 24 '16 12:11 tangxinfa

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

yahoocla avatar Nov 24 '16 12:11 yahoocla

CLA is valid!

yahoocla avatar Nov 24 '16 12:11 yahoocla

Already aggreed, please check again.

tangxinfa avatar Nov 25 '16 12:11 tangxinfa

I like the idea, but the "keepalive" name is confusing to me. Squid (an HTTP proxy) calls this "stale while revalidate" though that's too long for us here :) Perhaps "useStale" instead?

drewfish avatar Nov 29 '16 17:11 drewfish

It might be worthwhile to mention the useStale callback in the "advanced caching" section in README.md.

drewfish avatar Dec 19 '16 17:12 drewfish