blink-diff icon indicating copy to clipboard operation
blink-diff copied to clipboard

Ignores completely new additions

Open stevenvachon opened this issue 8 years ago • 4 comments

... that are beyond the boundaries of imageA.

For example, with this code:

new BlinkDiff({
  hideShift: true,  // hide anti-aliasing differences (from composited image)
  imageA: imageA,
  imageB: imageB
})
.run((error, result) => console.log(result.differences);

... these two images result in a logged 0;

imageA: imageA imageB: imageB

stevenvachon avatar Oct 24 '16 15:10 stevenvachon

This is because blinkdiff always clips the images to the minimum of the two

benzaita avatar Dec 05 '16 09:12 benzaita

I think that this behaviour should be optional. Does it throw errors otherwise?

stevenvachon avatar Dec 05 '16 14:12 stevenvachon

I totally agree (I do not maintain this repo, though)

benzaita avatar Dec 05 '16 20:12 benzaita

Also to the best of my knowledge it does not throw an error. It simply compares the common part (dimension wise) like you saw.

benzaita avatar Dec 05 '16 20:12 benzaita