Jakob Schnitzer

Results 234 comments of Jakob Schnitzer

I don't want to add a second "conversion" dropdown that behaves differently from the conversion dropdown on other pages, so it would have to handle the non-currency conversion options (at...

I don't know whether this would be feasible to implement with the way that this option is currently provided, as we'd have to rewrite the option in the input file...

I don't want to introduce a whole different kind of option for this use case. It seems like a (persisted) frontend toggle is enough. This could be solved with a...

> Do you have specific plans on what such a page would look like? Basically a table of all trades with columns for book value, PnL, etc.

I find this to be consistent. I think it's sensible that the transaction date is used to look up the price. Then of course the converted sums might not match...

> So would you modify it or add a new option? I think you misunderstood - I find the current behaviour to be consistent: "I think it's sensible that the...

I think we should keep the current behaviour as default, but we can add the date as an additional parameter for the conversion option to force one date to be...

Hey, thanks for this PR :) I was initially waiting for this to get into a state that passes CI and then it dropped off my radar. Overall this is...

I just checked out this branch to see which linters complained - the first one was prettier, which can be run (and automatically fixes the files) with `make lint`. prettier...

I can't reproduce this. Have you force-reloaded the browser to ensure you don't have outdated cached frontend code running? Are there errors on the Javascript console? Does this also happen...