Amos Jeffries

I am leaving the FD related changes under this PR, so it is still relevant. I will get back to this when they are merged and the PR branch can...

Okay, updated now to use SBuf with most being constants instead of dynamic allocation.

I adjusted the text right after this last commit. The driver behind this PR is still the GCC-8 build errors with the cause being char* string truncation warning promoted by...

I'm not exactly sure about any of the details for this. Approval to use the scanner on Squid sources came through today and what you can see from the "Checks"...

> > [Warning](https://github.com/squid-cache/squid/pull/693/checks?check_run_id=2656223082): Code scanning cannot determine the alerts introduced or fixed by this pull request, because 1 analysis was not found. > > Would it be possible to fix...

The analyzer is now working for basic builds. We just need the found issues to be resolved before this can merge.

@rousskov, can you review the new texts please? I'd like to get the downstream bugs abut this closed next months release.

> Since 69bb939, AcceptLimiter stores CbcPointers, not raw pointers. AFAICT, it validates those pointers before dereferencing them (except in removeDead() called from the job object itself). Could you please detail...

One other implementation would be to have each TcpAcceptor maintain its own deferred queue instead of a global AcceptLimiter instance. The removeDead() would be replaced by normal RAII erasure when...

Genius. So simple its brilliant. Thank you! I will implement that latest and push in a day or so for a new review.