Amos Jeffries

Results 156 comments of Amos Jeffries

> What justifies iocb_table existence in the refactored code? Only that I have run out of time for more refactoring of this table. It is just enough to redux the...

FTR: updated description to reference the Coverity issue highlighting this dlink container as an resource leak issue (minor).

In regards to the future of this data structure / container. It is one of the state caches I want to be using the ClpMap for when it gets merged.

I don't think this change makes much difference either way, except to the coverity results. Since Alex and I are just debating the internals and final optimizations I think that...

> FWIW, I do not understand why this PR was labeled as a `feature`. You can see how I have been classifying some changes as "Developer Interest changes" in [https://wiki.squid-cache.org/Squid-4]....

Status update: I have closed the discussion threads where I am satisfied. Still have to do a re-review of the new code changes, and merge the listening port PRs for...

Reviewed the API changes in src/anyp/TrafficMode.h and remaining requests are still relevant. Please resolve those name/definition issues before we continue on to adjust their callers in light of the finalized...

> @yadij, during the next review round, I urge you to focus on truth tables rather than method names or descriptions. Once you have no blocking issues with how the...

FTR; I have re-read and reviewed this discussion on a weekly or so basis and my thinking has not been significantly changed by the responses given to my change requests....