TastyToast icon indicating copy to clipboard operation
TastyToast copied to clipboard

Published 20 hours ago • verified publisher icon yadav-rahul

enum for toast type

Open pkarira opened this issue 7 years ago • 2 comments

It would be better to use enum for toast type , storing them as integer seems to be a bad practice .

pkarira avatar Apr 04 '17 20:04 pkarira

@deep110 What do you think about this? Also, Can you please review this PR #27 .

yadav-rahul avatar Apr 05 '17 16:04 yadav-rahul

@yadav-rahul enums are just used to group specific type of constants like that is done in #27. It is purely implementation viewpoint, there is no right or wrong from coding point of view. Though I would advise to switch to enum type. Because it would look cleaner and differentiate between Toast length and Toast type. And for the PR, it could be merged if you fix the error so that CI build is passed.

deep110 avatar Apr 05 '17 19:04 deep110