medium-editor icon indicating copy to clipboard operation
medium-editor copied to clipboard

Paste Extension: keyboard shortcut paste not triggering editablePaste with event

Open marcelotedeschi opened this issue 3 years ago • 0 comments

Description

Hi! Thanks a lot for the add-on, it's awesome :)

I'm currently having the following issue: When trying to paste using cmd + v on the contenteditable, the editablePaste event triggered does not contain the original event information. Instead, the editable element is returned three times:

https://github.com/yabwe/medium-editor/blob/d113a74437fda6f1cbd5f146b0f2c46288b118ea/src/js/extensions/paste.js#L252

From what I understand, this is manually triggered because the paste event happens inside of the pastebin.

Originally changed here: https://github.com/yabwe/medium-editor/pull/1099 and fixed, partially, here: https://github.com/yabwe/medium-editor/pull/1124

I understand the reason behind it, but I don't know why returning the same object three times is necessary, specially without sending the original event !

My use case is I want to allow pasting files, which I need to do after the past extension does its thing and triggers the editablePaste event. But without the original event information, it's impossible. Unless I'm missing something !

I appreciate the support and I can offer to create a PR if that helps :)

Steps to reproduce

  1. Paste using keyboard commands (cmd + v)
  2. Subscribe to editablePaste event trigger

Expected behavior: Receive the original paste event as a parameter

Actual behavior: A "fake" event object containing two times the same object is returned

Versions

  • medium-editor: 5.23.3
  • browser: Chrome v89
  • OS: Mac OS 10.15

marcelotedeschi avatar Apr 09 '21 15:04 marcelotedeschi