medium-editor icon indicating copy to clipboard operation
medium-editor copied to clipboard

Published 20 hours ago • verified publisher icon yabwe

When disableEditing is true, enable editing via toolbars.

Open tleewu opened this issue 6 years ago • 4 comments

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
New tests added? yes/not needed
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

Inspired by #1084

Description

Currently, when disableEditing: true and when you highlight a piece of text, you can see the Medium toolbar, but clicking on the buttons doesn't change the text since contenteditable=false.

image

Fix: allow toolbar editing when disable editing

medium-editing

This is my first time contributing to this repo - would love to hear your thoughts and suggestions!

tleewu avatar Jan 05 '18 20:01 tleewu

Coverage Status

Coverage decreased (-0.2%) to 94.285% when pulling 865c238e78cff3e08920fd6ac60748ca26631522 on tleewu:enable-toolbar-editing-when-edit-disabled into eef3ee0224a07121799f9d1389b3be4d1020937f on yabwe:master.

coveralls avatar Jan 05 '18 20:01 coveralls

@nmielnik could you perhaps take a look at this PR and let me know if this is a feasible merge?

tleewu avatar Jan 16 '18 23:01 tleewu

This should be pushed live by now?

harsharora04 avatar May 06 '20 20:05 harsharora04

Hey whats the update on this this is exactly what I need in my application

MethDamon avatar Aug 23 '21 15:08 MethDamon