medium-editor-tables icon indicating copy to clipboard operation
medium-editor-tables copied to clipboard

Improve for requirejs

Open sielay opened this issue 8 years ago • 3 comments

Your UMD won't work with requirejs, as you expect MediumEditor to be globally available and use use strict in the same mode and then invoke your factory without reference to root.

My change will be breaking so wroth making major version.

In case of requirejs usage you'd have to inject MediumEditor like

MeTables = require('medium-editor-tables')({
        MediumEditor: MediumEditor
    });

sielay avatar Sep 26 '16 13:09 sielay

Coverage Status

Coverage remained the same at 10.821% when pulling 77310ad863340d7b4c0fda6c0dd8260c3006b0ad on sielay:master into fe1e31366ed32e648535650f5f5e238afbb2f969 on yabwe:master.

coveralls avatar Sep 26 '16 13:09 coveralls

@sielay or @yazonnile any chance you could try to fix the merge conflict and push this up again? We'll be sure to get this merged quickly this time, we've been on a bit of a hiatus for a while

nmielnik avatar Feb 08 '17 03:02 nmielnik

I could really use this. I'm trying to use in an angular project and it's just not going to work as coded I don't think.

jmsunseri avatar May 17 '19 23:05 jmsunseri