medium-editor-tables
medium-editor-tables copied to clipboard
Improve for requirejs
Your UMD won't work with requirejs, as you expect MediumEditor
to be globally available and use use strict
in the same mode and then invoke your factory without reference to root.
My change will be breaking so wroth making major version.
In case of requirejs
usage you'd have to inject MediumEditor like
MeTables = require('medium-editor-tables')({
MediumEditor: MediumEditor
});
Coverage remained the same at 10.821% when pulling 77310ad863340d7b4c0fda6c0dd8260c3006b0ad on sielay:master into fe1e31366ed32e648535650f5f5e238afbb2f969 on yabwe:master.
@sielay or @yazonnile any chance you could try to fix the merge conflict and push this up again? We'll be sure to get this merged quickly this time, we've been on a bit of a hiatus for a while
I could really use this. I'm trying to use in an angular project and it's just not going to work as coded I don't think.