yabeda-rails icon indicating copy to clipboard operation
yabeda-rails copied to clipboard

Configurable controller and action default tags

Open liaden opened this issue 4 years ago • 2 comments

Note: This depends on https://github.com/yabeda-rb/yabeda-rails/pull/19 to work.

liaden avatar Mar 15 '21 14:03 liaden

Thank you for pull request!

But for now it looks quite application-specific. Will it be useful for an average user of this gem? Can you think of any use cases that are applicable for a lot of people?

Envek avatar Mar 15 '21 17:03 Envek

I don't mind this not being included since it might be fragile with the monkey patch of rails. I do think it is useful though for a lot of users though.

I think the value comes from being able to filter other metrics from other gems pretty easily. I can see which endpoint is queueing sidekiq jobs with yabeda-sidekiq and see which endpoints are making http requests with the yabeda-http_reqests plugin

I believe yabeda-sidekiq allows for similar functionality with https://github.com/yabeda-rb/yabeda-sidekiq#custom-tags

liaden avatar Mar 15 '21 18:03 liaden