eyre icon indicating copy to clipboard operation
eyre copied to clipboard

feat(color_eyre): add support to specify verbosity in HookBuilder

Open TheTollingBell opened this issue 1 year ago • 5 comments

In situations where setting the environment is unsafe it would be more convenient to manually specify the verbosity without using the environment at all.

TheTollingBell avatar Aug 13 '24 22:08 TheTollingBell

Looks good, I'm happy to merge this with the addition of some tests. Particularly what happens when conflicting verbosity is set via both the hook builder and the env.

yaahc avatar Aug 15 '24 20:08 yaahc

Sorry for being incommunicado for the past few days, I'll go ahead and fix Clippy failing. As it's configured right now, verbosity that is specified in HookBuilder overrides environment, though it is possible to write another function that would instead have environment override specified verbosity.

TheTollingBell avatar Aug 18 '24 19:08 TheTollingBell

Never mind about Clippy, all the warnings are not from changes in this pull request.

TheTollingBell avatar Aug 18 '24 19:08 TheTollingBell

clippy warnings should be fixed now

yaahc avatar Aug 29 '24 20:08 yaahc

@yaahc Is this ready to be merged, or is there something else I should do?

TheTollingBell avatar Sep 11 '24 15:09 TheTollingBell