eyre icon indicating copy to clipboard operation
eyre copied to clipboard

Support unstable-less nightly

Open thenorili opened this issue 1 year ago • 3 comments

This change attempts to put unstable features behind an opt-in feature flag as requested by issue #120. Unstable lints and compile_test.rs are both gated by this feature which is added unconditionally to all CI that touches more than just stable.

As expressed in issue #120, I have some concerns about needing to gate compile_test.rs behind feature = "unstable". I'm not certain that this unstable-less nightly eyre will work in production due to the reason that compile_test.rs fails: three of our dependencies, anyhow, thiserror, and proc-macro, all use a test for a nightly toolchain to gate unstable features. Maybe I'm wrong though and this change is sufficient!

thenorili avatar Nov 19 '23 07:11 thenorili

oh wow, it looks like public_in_private's been merged on stable!

https://github.com/rust-lang/rfcs/pull/3516

thenorili avatar Nov 19 '23 07:11 thenorili

I rebased to my other PR to get rid of the clippy fail, we can remove that before pushing if we want to send this first.

thenorili avatar Nov 19 '23 08:11 thenorili

Cc https://github.com/rust-lang/rust/issues/120804

RalfJung avatar May 06 '24 10:05 RalfJung