Jane Losare-Lusby

Results 180 comments of Jane Losare-Lusby

Yea, and I don't even think we could do a good job with the vtable. We might be able to do some shenanigans using autoref specialization inside of the `eyre`...

> but it's also pretty much the worst possible case for the current approach, which seems to assume that the boundary between eyre::Report and std::error::Error is also the boundary between...

> Then again, that still means that we lose the backtrace on the other end.. :/ Does `kube_rt` handle printing the error for you? Because if you have a chance...

> eyre::Report(kube_rt::controller::Error::ReconcilerFailed(eyre::Report(...))) Aah, yes, with this setup if the user used the extracter type I mentioned both Reports here would be able to skip their `Backtrace` capture and correclty use...

> Not sure how familiar you are with the inner workings of Kubernetes. I have almost 0 familiarity with it, so this explanation is appreciated. I think I'm gonna check...

Okay, so heres my understanding of how this works. Users provide a bunch of closures for the `controller` fn to provide retry rules and other things, and the various user...

> Not sure I've understood you correctly here, but I think it might make more sense once I've had a go with the new API. Fair enough. I've not finished...

if its possible to extract snafu backtraces and convert them to `std::backtrace::Backtrace` you could add a compat shim right before you convert to a `Report` that looks to see if...

as long as you convert the error to a `Report` in both branches that attempt to Bundle the backtrace it should work fine and not matter if you change the...

yea, I haven't finished that part yet. I plan on setting aside tomorrow to catch up on this and some other PRs, I'll let you know as soon as it's...