clp icon indicating copy to clipboard operation
clp copied to clipboard

fix submodule config and add build instructions

Open xiaokang opened this issue 2 years ago • 1 comments

References

Description

Validation performed

xiaokang avatar Mar 23 '22 13:03 xiaokang

Hey @xiaokang,

Thanks for submitting a PR! I have a few questions about it:

  • To download source dependencies, we actually switched from git submodules to a script. This is because when we publish a release, GitHub automatically generates a source code tar ball which doesn't include the submodules nor the .git files necessary to download the submodules (there seems to be an open issue about it). Are git submodules still useful for you even though we have the script?
  • We have build instructions for building the core component using a container here. Instead of your change, maybe we could add link to those build instructions in the main readme. What do you think?

kirkrodrigues avatar Mar 24 '22 09:03 kirkrodrigues