Michael Mifsud

Results 199 comments of Michael Mifsud

I've resolved the segfault. All tests are passing locally (OSX) on all Node LTS and current. We'll need to rejig CI a bit since the binary no longer builds on...

We have our first green N-API builds https://travis-ci.org/sass/node-sass/builds/404487187 Just for kicks the current hacked CI setup shows that binaries built on Node 10 work on other LTS Node.

@nschonni note this means we probably can't have node-gyp fallback to build

Sorry what I mean is that with N-API we can no longer compile the binary on Node < 10. So if the download fails there's no point node-pre-gyp falling back...

In my experiments binaries built on 10 run back until 6, but I couldn't get it to build on < 10 because the have different napi versions. I could be...

I have a call with some napi folk later in the week. I'll get some clarification On Tue., 17 Jul. 2018, 2:29 am Michael Mifsud, wrote: > In my experiments...

>As long as the memory leak scripts I wrote, don't demonstrate a leak we should be ok I can try running them locally as a verification. > I can try...

>Sorry what I mean is that with N-API we can no longer compile the binary on Node < 10 @nschonni looks like I was wrong about this. I must have...

Hey @realityking, a couple updates from today - I had call with some of the N-API folks this morning, and - had a chat with @nschonni It's now my expectation...

Partly, but largely because the typical user of node-sass either isn't in control of their node version or doesn't know how/why to change versions. It also introduces another barrier to...