ndb.nim
ndb.nim copied to clipboard
xzfc
#20 Add Nim2.0 support
Adds nim2.0 support, or at least I'll aim for a branch that's good enough to use in a norm fork for my own project. do with that as you will.
(Also see #22 which was the previous PR for this with a dummy branch, before I decided to make a temporary fork for myself until this is dealt with)
So because nim 2.0 introduced strict effects and you made use of the effects system, I had to fix a few tag things.
I wasn't aware of it before, but std/times has the TimeEffect. This hadn't been accounted for before, so I fixed that.
Now I can compile norm docs with this branch without having RootEffects everywhere.
Anyway, I just checked out the tests for norm and made use of my branch here in norm, since I can get those tests to run. Those tests run flawlessly for both sqlite and postgres, so I'll assume that ndb works well in general on this branch. Personally I consider the PR finished with that unless further editing suggestions are made.
Any news on this ? With 2.0 around the corner it'd be nice to have it working
Any news on this ? With 2.0 around the corner it'd be nice to have it working
I forked ndb and created lowdb, which is 2.0 ready. https://github.com/PhilippMDoerner/lowdb
My dependency of ndb comes from norm so it's not up to me but to @moigagoo. I don't know which is best for the 2.0 migration.
Then you'll be glad to hear that norm jumped over to lowdb as of 2.7.0 via this PR: https://github.com/moigagoo/norm/pull/186
Here the announcement for it: https://forum.nim-lang.org/t/6471#65566