logseq-fenced-code-plus icon indicating copy to clipboard operation
logseq-fenced-code-plus copied to clipboard

Well done and a suggest

Open vipzhicheng opened this issue 2 years ago • 7 comments

It's a must-have feature for someone and is implemented in a more natural way by implementing the new experimental API.

What I suggest is to just rename it to mermaid for users to easier search. And if you have other awesome ideas, they can be done in other new plugins.

Great job for all you have done 👍

vipzhicheng avatar May 09 '22 05:05 vipzhicheng

But mermaid seems to be only a part of this project, the immediate purpose of this plugin may not be just to support mermaid, maybe like its title, "logseq-fenced-code-plus", may get something more than that,

red-co avatar May 11 '22 04:05 red-co

Hi @vipzhicheng Thanks for your kindly suggestion :). As what's @red-co said, the intent of this project is not only to support one type of fenced code block. As an experimental project, if any types of fenced code are really needed by users, that should be considered built-in Logseq.

BTW. In fact, the runtime of the current Logseq plug-in system is a bit heavy, and it is a bit uneconomical to make a plug-in with very small functions. Best practice could consider categorization functionality, implemented centrally in one plugin.

xyhp915 avatar May 11 '22 05:05 xyhp915

OK, got you. So too many plugins could make Logseq slow. It's for sure that I installed at least 30+ and it's increasing.

vipzhicheng avatar May 12 '22 05:05 vipzhicheng

Just a quick note about discoverability of this plugin: I've found it by searching for "mermaid" in the marketplace, finding https://github.com/hkgnp/logseq-mermaid-plugin, and following the recommendation there.

ktosiek avatar Jan 06 '23 10:01 ktosiek

Just a quick note about discoverability of this plugin: I've found it by searching for "mermaid" in the marketplace, finding https://github.com/hkgnp/logseq-mermaid-plugin, and following the recommendation there.

This is how I ended up here as well. Thanks for writing this plugin! Maybe in the description for Logseq you could put "Support: Mermaid, other, other, other,"??

zenmushie avatar May 20 '23 18:05 zenmushie

Likewise, I found out about this by thinking mindmap (nothing), discovered mermaid (didn't know about that), then reading the comment. Most people won't do that.

The plugins need to be listed by what a user is trying to accomplish (mindmap, graphing), not how it works ("fenced code to an external library")

mrjcleaver avatar Sep 27 '23 19:09 mrjcleaver

Just a quick note about discoverability of this plugin: I've found it by searching for "mermaid" in the marketplace, finding https://github.com/hkgnp/logseq-mermaid-plugin, and following the recommendation there.

Same here. Thank you for this awesome plugin!

bjarnirafn avatar Dec 31 '23 13:12 bjarnirafn