Simone Fioravanti

Results 63 comments of Simone Fioravanti

Seems to be the first deprecation in CP... no standard ways!

I'll say somewhere that if something fails you can check `git remote -v`. As example i have a test installation where I've done a typo and you have to refer...

A more detailed explanation: - Check on GitHub.com that your fork is up-to-date, and if needed Update Branch - Check that your remotes are like those: ``` origin [email protected]:xxsimoxx/ClassicPress.git (fetch)...

> In any case, looking good but I cannot accept the change, as I am the author of the PR :( I haven't done any change, just asked for. You...

Done some tests after the discussion on Slack. In PHP < 8 when `disk_free_space` is disabled a warning is triggered (`PHP Warning: disk_free_space() has been disabled for security reasons`) and...

Before: `PHP Fatal error: Uncaught TypeError: round(): Argument ClassicPress/ClassicPress#1 ($num) must be of type int|float, string given in /Users/simo/Sites/allMyPlugins/src/wp-admin/includes/image.php:466` After: (image is uploaded without errors)

@viktorix yes, `wp core check-update` don't work in CP 1.4.2.

Agree @mattyrob. I've pushed a change to conditionally load the class.

@bahiirwa the command is `wp core check-update`. Do you mean you get `4.9.20` with `wp core version`? To manually check the PR you can change `$cp_version` in `wp-includes/version.php`.

Please check if DocBlock is correct, I've never used it.