xxchan

Comments expect those about `cargo-fmt` are resolved.

https://github.com/risingwavelabs/risingwave/pull/7816 It helped a lot! Thanks for the great tool. Tens of udeps are removed. The commit history in this PR also shows how I used it and the problems...

I think the work https://github.com/briansmith/ring/pull/1568 is already there. No more forks are needed.

Well, in this case maybe you should leave the review in that PR first :) I'm not sure which one works, but just want to say it's not friendly and...

I observed 390% + 250% usage while it's idle in the background, which makes my MacBook hot... (v0.8.17)

FWIW, I found plenty of "High CPU Usage" issues in electron 😅 https://github.com/electron/electron/issues?q=High+CPU+Usage

> Or you may record a performance profile so we can do some check: > [help.figma.com/hc/en-us/articles/360041468414-Record-a-Chrome-Performance-Profile](https://help.figma.com/hc/en-us/articles/360041468414-Record-a-Chrome-Performance-Profile) Such instructions about how to help provide more diagnostic info help a lot :p...

> Or you may record a performance profile so we can do some check: > [help.figma.com/hc/en-us/articles/360041468414-Record-a-Chrome-Performance-Profile](https://help.figma.com/hc/en-us/articles/360041468414-Record-a-Chrome-Performance-Profile) Please try to provide more information according to this instruction above.

I think this behavior is defined in [KIP-289: Improve the default group id behavior in KafkaConsumer](https://cwiki.apache.org/confluence/display/KAFKA/KIP-289%3A+Improve+the+default+group+id+behavior+in+KafkaConsumer) (Instead of https://github.com/apache/kafka/pull/7943, which just changed `null` to `None` IMO) [INTRODUCTION.md](https://github.com/confluentinc/librdkafka/blob/master/INTRODUCTION.md) mentioned KIP-289 is...

BTW, if you don't want consumer groups being unnecessarily created, I think you can just disable `enable.auto.commit`, and specify an arbitrary `group.id`. In this case it doesn't seem to have...