xxchan

Results 182 comments of xxchan

As discussed offline (https://risingwave-labs.slack.com/archives/C034U0NH5ND/p1654588390981939), to support the functionality at the beginning, we choose to store the original SQL as a temporary solution. The main concern of storing logical plan is...

`nightly-2022-08-18` works, and `nightly-2022-08-19` breaks https://github.com/rust-lang/rust/commits/master?since=2022-08-18&until=2022-08-18

```rust trait Trait {} type TAIT = impl Trait; struct Bar; impl Trait for Bar {} fn foo() -> TAIT { Bar } // ok async fn bar() -> (TAIT,...

Caused by https://github.com/rust-lang/rust/pull/99860 Any ideas? cc @oli-obk @compiler-errors

`nightly-2022-05-24` also works (a version before #97346 which is reverted by #99860

Just tested it and I can confirm it works now! Thanks! BTW, what about adding this issue as a test cast?

The issue can be closed?

> This should return Err(LxError::EINVAL) or Err(ZxError::INVALID_ARGS). OK, I can fix this. > bitflags contains all valid bits What do you mean by this? Isn't that already ensured?