travel icon indicating copy to clipboard operation
travel copied to clipboard

As a Travel website user, I need a rating to understand review scores on a given post

Open postphotos opened this issue 6 years ago • 8 comments

postphotos avatar Mar 23 '18 05:03 postphotos

Note that this will be resolved within #39.

miina avatar Apr 17 '18 13:04 miina

Request For Testing

Hi Claudio, Could you please test this?

  1. You can make a comment with a rating on a single adventure page
  2. That rating appears as part of the averaged rating at the top of the page, and the search page
  3. Ratings appear per the designs

kienstra avatar Apr 27 '18 22:04 kienstra

Rating section captures moveover/click as user moves cursor from right to left rather than left to right in IE11 (all other browsers fine): image

Recommending more space between fields and label below it: image

Star ratings crowd into the share icons on mobile (this image is from an Android7.0 device - happening on iPhone as well): screenshot_20180505-105056

csossi avatar May 05 '18 14:05 csossi

The star rating is actually not supported in IE11. I did not know this as it was not mentioned in the example https://ampbyexample.com/advanced/star_rating/

@kienstra I think we should have it switch to the old select box if IE11 is detected.

DavidCramer avatar May 06 '18 05:05 DavidCramer

Star Rating In IE11

Hi @DavidCramer, Good idea to use the old <select> for ratings in the output function if it detects IE11. I think the global $is_IE should be good for this, as 11 is the only version of IE that WordPress supports. And it worked locally, when testing this with IE11.

Do you have time to implement this? Thanks, David.

kienstra avatar May 06 '18 20:05 kienstra

Thanks For Testing

Hi @csossi, Thanks for catching these issues.

Star ratings crowd into the share icons on mobile (this image is from an Android7.0 device - happening on iPhone as well):

Thanks, we'll work on a fix for that.

Recommending more space between fields and label below it:

Good point. PR #80 (awaiting merge) should handle that.

kienstra avatar May 06 '18 20:05 kienstra

@kienstra Ye, I can do it today. Will be pretty easy.

DavidCramer avatar May 07 '18 04:05 DavidCramer

Status

Thanks to @DavidCramer's PR #81, all of the points here are applied, expect for:

Star ratings crowd into the share icons on mobile (this image is from an Android7.0 device - happening on iPhone as well):

kienstra avatar May 08 '18 20:05 kienstra