travel icon indicating copy to clipboard operation
travel copied to clipboard

Published 20 hours ago • verified publisher icon xwp

Generate styling of adventure CPT single based on mockups + AMP Start

Open postphotos opened this issue 6 years ago • 3 comments

As a user, I expect AMP-valid CSS styling to render on top of the adventure CPT single template's generated HTML markup.

Related to #7.

Mockups are available here:

  • https://www.figma.com/file/L14jTE7iNGOE7DH57Ro7ncyu/Travel-Theme
  • https://ampstart-iframes.firebaseapp.com/templates/travel/travel.amp

postphotos avatar Apr 10 '18 16:04 postphotos

Request For QA

Hi Claudio, Could you please test this page, which uses the single 'adventure' template? Please use the "Product" page from the design. The carousel was changed, and is expected to be different.

kienstra avatar Apr 18 '18 15:04 kienstra

@kienstra - Was the styling of share icons meant to change from this (design): image to this: image

csossi avatar May 02 '18 18:05 csossi

@csossi The amp-share component doesn't give flexibility to change the color of the icon, but only the color of the background.

https://ampstart.com/components#links-and-sharing Screenshot of the important bit: http://cloud.urldocs.com/1N3T1D1b3438

For follow icons (linking to the actual social pages of the website for example), one can use SVGs and hence any color needed for the icons themselves.

mehigh avatar May 02 '18 20:05 mehigh