travel icon indicating copy to clipboard operation
travel copied to clipboard

Generate styling of homepage based on mockups + AMP Start

Open postphotos opened this issue 6 years ago • 5 comments

As a user, I expect AMP-valid CSS styling to render on top of the homepage's generated HTML markup.

Related #12.

Mockups are available here:

  • https://www.figma.com/file/L14jTE7iNGOE7DH57Ro7ncyu/Travel-Theme
  • https://ampstart-iframes.firebaseapp.com/templates/travel/travel.amp

postphotos avatar Apr 10 '18 16:04 postphotos

@mehigh, can you give us a status update on this so we can update the sprint board? Thanks! :)

postphotos avatar Apr 18 '18 15:04 postphotos

I've just issued the PR for this and assigned it to Miina for code review: https://github.com/xwp/travel/pull/62

mehigh avatar Apr 21 '18 21:04 mehigh

Request For Testing

Hi Claudio, Could you please test the homepage, comparing it to the design?

kienstra avatar Apr 28 '18 00:04 kienstra

Thought it best to just point out all differences - am sure some are likely "ok as is"

Site: "Search for adventures" - Design: "Where would you like to go?" (2 locations) Site: "Start date" - Design: "Departure" Site: End date - Design: "Return" Site: "From The Blog" - Design: "From the blog" (plus, "blog" box is much larger in Design than on Site) Site: "Top Adventures" - Design: "Top Adventures Near You"

csossi avatar May 10 '18 17:05 csossi

Request To Verify

Hi @csossi, Thanks for bringing up these points.

@postphotos, could you please verify that we're alright with the first 3 points that @csossi raised above?

The last 2 points are (mainly) corrected with changes in the editor:

Site: "From The Blog" - Design: "From the blog" (plus, "blog" box is much larger in Design than on Site) Site: "Top Adventures" - Design: "Top Adventures Near You"

kienstra avatar May 11 '18 21:05 kienstra