stream icon indicating copy to clipboard operation
stream copied to clipboard

Prevent sprintf errors by escaping % in form title

Open krokodok opened this issue 1 year ago • 1 comments

Fixes #1445.

Straightforward escaping of % in $post->post_title with %% prevents the error.

Checklist

  • [ ] Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • [x] I have tested the changes in the local development environment (see contributing.md).
  • [ ] I have added phpunit tests.

Release Changelog

  • Fix: Describe a bug fix included in this release.
  • New: Describe a new feature in this release.

Release Checklist

  • [ ] This pull request is to the master branch.
  • [ ] Release version follows semantic versioning. Does it include breaking changes?
  • [ ] Update changelog in readme.txt.
  • [ ] Bump version in stream.php.
  • [ ] Bump Stable tag in readme.txt.
  • [ ] Bump version in classes/class-plugin.php.
  • [ ] Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

krokodok avatar May 15 '24 10:05 krokodok

@kasparsd Tried to complete the % escaping, analogue to https://github.com/xwp/stream/pull/1485.

krokodok avatar Jun 24 '24 17:06 krokodok

Superseeded by https://github.com/xwp/stream/pull/1508.

krokodok avatar Jul 22 '24 15:07 krokodok