stream icon indicating copy to clipboard operation
stream copied to clipboard

Notice in admin dashboard on WP trunk

Open ryelle opened this issue 2 years ago • 0 comments

Activating Stream on WP trunk (WordPress 6.0-alpha-52609) triggers a notice via _doing_it_wrong:

Notice: Function add_menu_page was called incorrectly. The seventh parameter passed to add_menu_page() should be an integer representing menu position. Please see Debugging in WordPress for more information. (This message was added in version 6.0.0.) in /var/www/html/wp-includes/functions.php on line 5768

The menu position is set here:

https://github.com/xwp/stream/blob/489fb8777047f6c61599e16ba28c375263602a27/classes/class-admin.php#L321-L328

but the comment about decimal points to avoid collisions is not true anymore.

System Information

  • Stream plugin version: 3.8.2
  • WordPress version: 6.0-alpha-52609

ryelle avatar Mar 07 '22 16:03 ryelle