Xiao Wang
Xiao Wang
> Do you foresee any further updates to the PR? Not for now.
We have talked to your team offline several times. I'm not expecting any big concerns. @adrawatcisco, @nokia1adam, @rolandphung, @aredmon8551 approve to merge? If no objection by 2023-04-11, I"ll go ahead...
> Just a nit on the process, can we get the relevant pyang output in the description? Ah, forgot that. Done. Thanks!
/gcbrun
I kinda agree with @nokia1adam, making it a explicit field for the protocol specific meaning (e.g. instance-id) seems ok. This avoid binding some protocol specific semantics to an abstract filed...
Hi @VijayKestur, Per the [election_id description](https://github.com/openconfig/gribi/blob/4ec9ff49dc8c3a80079043895cb079511ce0b9db/v1/proto/service/gribi.proto#L97-L123), the election happens externally to the gRIBI server. gRIBI server enforces the election result. So, we expect the new primary increases the election_id monotonically...