vial icon indicating copy to clipboard operation
vial copied to clipboard

Unmaintained (?) + fork

Open sigaloid opened this issue 3 years ago • 3 comments

While anxiously awaiting the return of @xvxx from a fishing expedition [1], I forked the repo and made a few improvements. Glad to contribute upstream when the maintainer returns, but until then, I won't make a bunch of PR's for each one. I accepted #10 #11 #7 #6 + a few others. a list:

  • added proper cookie support, fixed cookies (which were previously broken, only parsing the first cookie)
  • added cookie tests
  • clippy formatting
  • resize threadpool when more than minimum_threads are being used at once (dynamically scale with demand)
  • thread timeout set to 1s (slow loris attack prevention)
  • remote_addr field from #6
  • changed cookie crate to one that is (sort of) compliant
  • added more github actions
  • fixed arithmetic overflow https://github.com/sigaloid/vial/issues/5
  • fixed OOM that would flood memory upon carefully-crafted header https://github.com/sigaloid/vial/issues/7
  • anything you want to contribute personally :D

Link: https://github.com/sigaloid/vial

1: image

sigaloid avatar Oct 23 '21 03:10 sigaloid

I reached out via email and apparently Chris had decided to take a year off. Hopefully, he'll return early since his stuff has started to gain some traction

JEBailey avatar Oct 27 '21 19:10 JEBailey

Thanks, that makes me happy, hopefully some of these fixes can be upstreamed. :D

sigaloid avatar Oct 27 '21 22:10 sigaloid

Hi @xvxx, I have not implemented compression correctly and as-is it's disabled (the code is set to use compression if the feature is enabled but I've removed the feature in Cargo.toml so it can't be enabled). If you're willing to merge the changes (there's some conflicts :disappointed:) I have created a PR: #15

It's relatively large and I can answer any questions you may have (and of course change anything as you see fit) if you decide you want to merge.

sigaloid avatar Jan 08 '22 20:01 sigaloid

Hi @sigaloid, I merged some of your edits, thank you! Happy to review any other PRs you have.

xvxx avatar Nov 16 '22 00:11 xvxx