James Xu
James Xu
Agree with @bbatsov that vertically alignment will cause some unneeded change when add a longer name in the let.
`supervisor` doesn't seed in the PR?
change the package of `ShellBolt` makes this PR a breaking change: user code need to be modified to use the new package, is it really necessary?
Yeah, understand your concern. I personally like the other option your suggested: all new code goes into the new package.
better add some comments for the new codes, e.g. `Emission`, `Immission`, it makes it easier for the future maintainer to understand the code.
A new config item should be added to `Config.java` and `defaults.yaml`, so developer can specify a custom serializer.
a minor comment: are the terms `Emission`, `Immission` used frequently in your code? seems not very easy to understand at first glance(my feeling may be wrong, since English is not...
@francis-liberty `Tuple` in storm is designed to represent the messages transfered between Spouts and Bolts. I think it's not appropriate to use it here.
haha, naming things is the most difficult part of programming. I think the new names you proposed are easier to understand than `Emission` and `Immission`.