Hong Xu

Results 374 comments of Hong Xu

This is what's happening in the container. The app still opens Port 5000, but Port 5000 in the container has now been mapped to Port 5001 on the host. If...

This seems like an oversight in the spec language (#12) that none of us happened to catch. @jedmao Do you recall anything regarding this?

@jedmao I don't think the language preserves the existing tests though. The current test says that if you have a colon after a value, it should be taken as part...

@florianb No objection from my side.

@florianb #29 is only a clarification PR -- it doesn't require any changes related to the tests. I think it's safe to approve and merge if you agree with the...

> Following up --- it looks like #29 and [editorconfig/editorconfig-vote#6](https://github.com/editorconfig/editorconfig-vote/issues/6) are contradictory on the surface. To help out [dotnet/roslyn#44596](https://github.com/dotnet/roslyn/issues/44596) , could we define it one way or the other? @cxw42...

I agree with these. We probably also want a definition subsection that defines several concepts, such as "properties," "values," etc. in File Format. I also think the last section for...

@cxw42 It seems like most of the content is also applicable to general use (e.g., what is a property when a user sees a list of supported properties?). Since clarifying...

I've updated the content. Would you like to [check it out](https://editorconfig-specification.readthedocs.io/en/latest/)?

I also tend to agree now we better explicit state that inline comments are not supported. Often people simply assume their implementation's choice of the "undefined" behavior. This issue may...