Boying Xu

Results 18 comments of Boying Xu

Adding some comment for anyone who will continue review or improve the code. And as `IM_ADVANCE_WORD` is idempotent, `if xxx IM_ADVANCE_WORD(); if yyy IM_ADVANCE_WORD();` should be changed to if-elseif block....

Hi Ocornut, I’ll work on preparing a PR and adding test cases. Let me summarize the current status: 1. PR #8838 provides a good baseline, and its history should be...

You’re right — `widgets_text_wrapped_2` is cleverly designed to use relative sizing, so it doesn’t rely on any specific font or size. In theory, it should still work even if certain...

Hi again, I’ve completed the test cases — please take a look when you have time. The new tests are named `widgets_text_wrapped_cjk_XXX`, and they exercise the function `ImGui::GetFont()->CalcWordWrapPositionCJK`. **Related commits:**...

No worries — we can keep this issue open and gather feedback from other users as it comes in. I appreciate your feedback, and I’ll continue refining things as time...

Hi, I tested your PR in my project and it works well — nice job! I also reviewed the code and have a couple of findings: 1. Emojis could be...

Thanks, I’ve sent the PR. Below is a minimal demo showing how I’m using the new callback: ```c++ params.callbacks.ThemeChanged = []{ puts("Theme changed"); ImVec4 bg = ImGui::GetStyle().Colors[ImGuiCol_WindowBg]; float luminance =...

``` 1f7f1f54af38b0350d8c0008b096a9af6de299c7 3pp/imgui (v1.92.2b-docking) ``` I meet the same issue, in my case, I see different render size for Asian language and English, if I load the font with size_pixels...