Xuan

Results 36 comments of Xuan

Hi @jdehaan , I think the solution in https://github.com/tools-aoeur/opentelemetry-ruby-contrib/pull/2 looks great. Would you mind open the PR here and we can start the review.

> I find it unusual that there is a cross language repo with all implementations in a single repo since most language specific implementations are in their own repositories. I...

> @xuan-cao-swi - Are there any tests I should run using both your opentelemetry-lambda PR and this one? I will create a detailed step to test lambda-related instrumentation.

@kaylareopelle I have created a [gist](https://gist.github.com/xuan-cao-swi/151a8348504b4c4fcd4019a5aa05d82a) for the steps; but let me know if it's uncleared or failed.

> I wasn't able to get the telemetry data into New Relic, but I don't think this needs to be a blocker for the PR. Besides that, everything worked as...

I have added another instruction/result [here](https://gist.github.com/xuan-cao-swi/f75925a1dc290588de7e48b5edf5fe83) that I was experimenting with Jaeger on aws lambda instrumentation. This instrumentation can also help complete the lambda layer build on [opentelemetry-lambda](https://github.com/open-telemetry/opentelemetry-lambda)

> @xuan-cao-swi While reviewing https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/887, I noticed you made a few changes to release-please-related files. Do those changes need to be made for the lambda gem as well, or are...

> It looks like we're getting close, @xuan-cao-swi! Is there anything else you were hoping to accomplish before we sync with main and merge this in? Hi @kaylareopelle , no,...

I think it should be ok as it is an option and the rationale behind it seems logical to me. However, I do have a few formatting suggestions, which you...

Could you provide how you do the otel initialization that set the custom logger (e.g. OpenTelemetry::SDK.configure )? Have you tried following config to set the custom logger? ```ruby OpenTelemetry::SDK.configure do...