webassemblyjs icon indicating copy to clipboard operation
webassemblyjs copied to clipboard
verified publisher icon xtuc

TypeScript support

Open kurai-espoir opened this issue 4 years ago • 5 comments

It would be great if you added support for TypeScript users

EDIT: I didn't realized there was a types directory. Consider renaming the files from *.js to *.d.ts?

kurai-espoir avatar Aug 29 '21 08:08 kurai-espoir

I believe this types are used by webpack, if we rename the file we need to ensure webpack doesn't break.

Would you mind sending a PR?

xtuc avatar Aug 29 '21 17:08 xtuc

Sure. I'll send one by this week.

kurai-espoir avatar Aug 29 '21 23:08 kurai-espoir

I believe the files in the types directory are only for flowtype and will need more than renaming to make them work with typescript. I'm also interested in having typescript type declarations. Let me know if you'd like some help @kurai-espoir

pcardune avatar Aug 30 '21 18:08 pcardune

Long term I think we should remove flow in the repo and replace with typescript.

xtuc avatar Aug 30 '21 18:08 xtuc

Hi @xtuc, how do you see this happening -- by rewriting everything to TS, or by keeping the code as JS + adding TS types?

gustavohenke avatar Jun 04 '23 09:06 gustavohenke