Sven Sauleau
Sven Sauleau
closes #477
Attempt to fix https://github.com/xtuc/webassemblyjs/issues/405 The idea is to transform our `Index` that has either `Identifier` or `NumerLiteral` to a structure that contains both (the Identifier is optional tho). Notes: -...
Following https://github.com/xtuc/webassemblyjs/pull/238 Status: ```patch diff --git a/binary.wast b/binary.wast index 2c43d0c..26f5011 100644 --- a/binary.wast +++ b/binary.wast @@ -227,46 +227,46 @@ "integer too large" ) -(assert_malformed - (module binary - "\00asm" "\01\00\00\00"...
Wabt added the support https://github.com/WebAssembly/wabt/pull/831. We need to wait that wabt.js publishes a new version.
Would should have a tool that reads the producer section and an API that exposes it to Webpack.
https://github.com/xtuc/webassemblyjs/blob/f558c6c047187f24a2200ab04104f173de226794/package.json#L47-L48 Should be moved to devdeps.
@TimHambourger made a very useful test harness, we could integrate it in our CI somehow (if @TimHambourger is ok with that). Note we can keep a seperated repo.
Following the discussion in https://github.com/xtuc/webassemblyjs/issues/407#issuecomment-406505692. We are missing test for transformation on a LEB128 padded binary.
see https://github.com/WebAssembly/spec/blob/master/interpreter/main/main.ml#L5-L6