Sven Sauleau comments

Results 316 comments of


                                            Sven Sauleau

`npm run start` compiles crate in "dev" profile by default

It would be great if you can change the compilation message to indicate the env, :+1: You can find it here https://github.com/wasm-tool/wasm-pack-plugin/blob/b26fc434ef8c87b7807a0ddd68fae962c0b37ae0/plugin.js#L70

Web Worker example

Would you mind sending a PR? What were your troubles?

Clarify / define Node.js story

I missed your issue @RReverser, sorry. I opened https://github.com/rustwasm/team/issues/204 a lot ago, the bundler team happen to own https://github.com/wasm-tool/node-loader. The nodejs integration seems to be quite related to the bundler...

cannot init template

That's strange, the only commands that we spawn during installation are git and npm, I assume you both have this commands. @fitzgen I can't see the appveyor builds, are we...

Update template to webpack 5

@JohnForster this is likely an issue in the code that wasm-bindgen generates.

Source maps applied to wasm binaries

I would be interested @littledan, even if I didn't participate much here?

Babel Upgrade Online

Nice! could that be integrated into the Babel website?

Add macros section to readme.md

Thanks for the PR. I'm not sure what we should do because there's already `babel-macros` and `idx` in other sections of the README. Should we merge them into a `macro`...

inconsistency: top-level setTimeout, others

It fails in the preview but I'm sure it works in production, have you tried it?

inconsistency: disallow `new Function()` eval() loophole

I added a few cases in your PR that should be disallowed. The rule is any evaluation of any generated code is disallowed (wasm is one non obvious case).