BetterSpades icon indicating copy to clipboard operation
BetterSpades copied to clipboard

Fix xtreme8000#96 error when starting client with aos version in url

Open dany-on-demand opened this issue 1 year ago • 2 comments

The reason this happens is because network_identifier_split at some point got support for "255.255.255.255" ipv4 format, and if you have the suffix it thinks that it's parsing that. This hotfix works in either case (tested). The information about whether the server is .75 or .76 is not needed as it is already handled heuristically in network_connect and read_PacketWorldUpdate

dany-on-demand avatar Jan 08 '24 01:01 dany-on-demand

  • There will be out of bounds accesses if strlen(str) is less than 5.
  • I don't see any need to return str

xtreme8000 avatar Jan 09 '24 18:01 xtreme8000

https://github.com/forked-from-1kasper/tigerspades/commit/247f2ca6ae2870e131ac62135fe3df1e36b082f1 also has a different solution, but like I said as far as I know this is entirely pointless, distinguishing versions at this point is unnecessary and doesn't do anything

dany-on-demand avatar Jan 12 '24 14:01 dany-on-demand