xtqqczze
xtqqczze
@adityapatwardhan, @SydneyhSmith Can you merge?
I wonder whether we should handle `Socket.OSSupportsUnixDomainSockets is false` during argument validation, or later in `CreateHttpClient`. In any case, would it be better for the error to have `ErrorCategory.NotImplemented`?
> @SteveL-MSFT It was handled in the following commits following @xtqqczze 's suggestions: [d9ec5c4](https://github.com/PowerShell/PowerShell/commit/d9ec5c45fd2d2caea538af3679de453da0b7d752); [bd5c4d6](https://github.com/PowerShell/PowerShell/commit/bd5c4d60614cfa524a2aa9b56c762c1e01801e00); [f7ec7e8](https://github.com/PowerShell/PowerShell/commit/f7ec7e84ca997ef62625f1b5c412481bd2100692); [2b9a2b9](https://github.com/PowerShell/PowerShell/commit/2b9a2b901b403101be06f2ea5b92edfb9ce0df1d) and removed as asked by @iSazonov ([#19343 (comment)](https://github.com/PowerShell/PowerShell/pull/19343#discussion_r1163772728)) [e7090f3](https://github.com/PowerShell/PowerShell/commit/e7090f3115db44b16db3ad616742d4cdb2b264e5) I agree with @iSazonov,...
> > We prefer `#if UNIX` over runtime check. > > Change made. > > Note: the codebase contains a significant number of runtime tests e.g. `if (Platform.IsWindows)...` @iSazonov FYI,...
> This time the MacOS CI fails... Failing test `Test-Connection.MTUSizeDetect.MTUSizeDetect works` is unrelated. The test is flaky.
I see #19040 reverted the changes to `build.psm1` that required `pwsh`, closing. https://github.com/PowerShell/PowerShell/blob/e6e34adfb2cf0d02fb450b26ab92d081dc268c0c/build.psm1#L22 https://github.com/PowerShell/PowerShell/blob/089212c6b17356826ae88d4cfe92f7df534851e3/build.psm1#L22 https://github.com/PowerShell/PowerShell/compare/089212c6b17356826ae88d4cfe92f7df534851e3~1..089212c6b17356826ae88d4cfe92f7df534851e3#diff-1eb6991ceacad71a638a32bcf0a4ec906c7ec150f5086732ab6d7702a624914aL22 GitHubComparing 089212c6b17356826ae88d4cfe92f7df534851e3~1..089212c6b17356826ae88d4cfe92f7df534851e3 · PowerShell/PowerShellPowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account...
Related issue: #14054.
Its seems calls to BinaryFormatter APIs are disabled in .NET 7.
Superseded by #18635.
@iSazonov Could you approve?