xtofl

Results 17 comments of xtofl

Great remark! You are right: I'll be happy to redo the commit to only contain the essential changes.

Wait - no: the essence is that the the object is in a 'valid' state always, i.e. before any exception can be thrown, the `_devices` member has to be set.

I went ahead and simplified the change.

Yes sure. That was a more theoretical idea, and it doesn't directly map onto Python, but onto languages like C++, where class hierarchy construction/destruction order is determined by the language....

> What I'm thinking is that the root issue is that `shutdown` is being called when the object has not yet been fully initialised. Even if you move the declaration...

Indeed, the object-oriented convention is that only a successfully initialized object is valid for use. In principle, there's the `base` object and the `sub` object. If the `sub` object constructor...

For the time being, I forked (as many did) and published a no-warn version of 2.0.0. https://pypi.org/project/imreg-dft-nw/ I might yank it at a certain time, though.