xterm.js icon indicating copy to clipboard operation
xterm.js copied to clipboard

Official solution for custom links (regexp)

Open Tyriar opened this issue 1 year ago • 2 comments

Discussed in https://github.com/xtermjs/xterm.js/discussions/5223

Originally posted by afska November 20, 2024 Hi. Thanks for this great project. I wanted to ask if we could get an official solution to register links with any format.

Like https://github.com/LabhanshAgrawal/xterm-link-provider but... official 😅 The problem with that project is that it's not updated anymore, it uses an old Xtermjs version and it has some issues when handling line breaks & emojis (which I attempt to solve in that PR) but also incompatibilities with addon-fit (like links not formatting well if they end in the last character of a line).

I ask primarily because maybe you have a more generic solution working and it'd be a matter of just exposing it. I think a lot of users will find it useful!

Tyriar avatar Nov 22 '24 13:11 Tyriar

I want to work on this issue, Can you assign me?

abhishek-kumar-91 avatar Feb 15 '25 19:02 abhishek-kumar-91

Add a custom validator field in options, but LinkComputer have not permission to visit it, cause it contains in LinkProvider. So i have to pass it as parameters, is that acceptable?🤔 I tried to submit a PR for this issue, but I've been stuck on the test for a long time. It's really frustrating. 😢 To test the custom validator it need aslo change the options.urlRegex too😰. I don't have too much experience on xterm so it very hard to me to figure out what wrong in the test happend☹.

ulgyd0gg avatar May 26 '25 06:05 ulgyd0gg