xterm.js icon indicating copy to clipboard operation
xterm.js copied to clipboard

Make addon peer dependencies friendly with npm

Open Tyriar opened this issue 1 year ago • 2 comments

Right now we have stable xterm.js declared as a peer dependency of the beta addons. This ends up causing issue with npm https://github.com/microsoft/vscode/issues/196795#issuecomment-2298982911. To fix this we probably need to update the peer dependency when we update the version of the addons on publish

Tyriar avatar Aug 21 '24 11:08 Tyriar

Glad to see a move back to npm - it is not only the official package installer, it also got much better lately, but more importantly we encountered issues with yarn in other projects, where its package cache might apply the wrong package version (and we had to switch back to npm, mind you - those issues are all around ESM support in various 3rd party packages, grrr).

jerch avatar Aug 21 '24 13:08 jerch

npm has been plenty fast for a long time and I think we also switched before package-lock.json was a thing.

Tyriar avatar Aug 22 '24 01:08 Tyriar