xterm.js icon indicating copy to clipboard operation
xterm.js copied to clipboard

Published 20 hours ago • verified publisher icon xtermjs

DOM renderer may clip overline

Open Tyriar opened this issue 2 years ago • 4 comments

It works in this browser (Edge/macOS) but gets clipped because of overflow:hidden.

Image

Tyriar avatar Sep 07 '23 20:09 Tyriar

Eww still so many issues with the DOM renderer, seems it fall a bit behind over the years :sweat_smile:

jerch avatar Sep 08 '23 05:09 jerch

Overline is approximately equal to the underline on the previous line and has been processed by overflow.Should we use a special method to handle it?...

tisilent avatar Sep 08 '23 11:09 tisilent

@tisilent I think that would be fixed automatically, once we resolved #4632.

jerch avatar Sep 08 '23 11:09 jerch

@jerch I was looking into general renderer playwright tests yesterday and the progress is promising 🙂

Tyriar avatar Sep 08 '23 14:09 Tyriar