Underline with canvas uses less spacing

[Tyriar]

VS Code issue: https://github.com/microsoft/vscode/issues/158874

• set setting terminal.integrated.gpuAcceleration: canvas
• in a terminal type

echo -e "\x1b[4:3m"  # curly underline
echo -e "\x1b[4:4m"  # dotted underline
echo -e "\x1b[4:5m"  # dashed underline

• set setting terminal.integrated.gpuAcceleration: on

Note that the spacing of the underline differs: with canvas it is a bit too close to the text

[Tyriar]

Here's a reference for how Word renders 12, 24, 36 and 48px Calibri:

[jerch]

@Tyriar Is there a middle ground possible? Its just a gut feeling, but kinda both seem slightly off to me - like canvas is too close and webgl too far?

On a sidenote: In typography there are some support lines how far glyphs should run (found with a quick search: https://material.io/design/typography/understanding-typography.html#type-properties) - maybe there is also an official way how to do it for different underline styles (not mentioned in the link)?

[Tyriar]

@jerch I had a bit of a WIP this morning for this where I get the alphabetical text baseline and push it down 1-2 css pixels which looked good, I think that's the approach we should take for the upper cap of the underline