xterm.js icon indicating copy to clipboard operation
xterm.js copied to clipboard

OSC hyperlink support

Open Tyriar opened this issue 3 years ago • 1 comments

Previous attempts: https://github.com/xtermjs/xterm.js/pull/2904, https://github.com/xtermjs/xterm.js/pull/3904

Fixes #1134

This sets up the model side of multiple range support but does not implement it, there's an example in the demo test button that should work when it's done:

Screen Shot 2022-08-07 at 11 50 47 am

Tyriar avatar Aug 07 '22 14:08 Tyriar

This is basically done, I'm going to wait until next month to push it though considering the amount of changes that are already in this month.

Tyriar avatar Aug 08 '22 12:08 Tyriar

@Tyriar I know lots of people looking forward to get hyperlink support enabled in xterm. Lost of vscode users will be thrilled to see this in sooner.

ssbarnea avatar Aug 29 '22 07:08 ssbarnea

@ssbarnea should land in 1.72 🙂

Tyriar avatar Aug 30 '22 12:08 Tyriar

@Tyriar Oh well abit late to the party - do you think this should get a review? Sorry the PR kinda went unnoticed to me...

jerch avatar Aug 30 '22 13:08 jerch

@jerch sure a review is always welcome! Can always react to feedback retroactively. I'm trying to integrate it with VS Code atm which is what https://github.com/xtermjs/xterm.js/pull/4087 is about

Tyriar avatar Aug 30 '22 14:08 Tyriar