xterm.js icon indicating copy to clipboard operation
xterm.js copied to clipboard

Published 20 hours ago • verified publisher icon xtermjs

PoC for protected flag

Open jerch opened this issue 3 years ago • 1 comments

Currently just a quickly hacked PoC for protected flag support (so far only tested manually on canvas renderer).

@stuboydl: Maybe try this one out?

jerch avatar Mar 25 '22 16:03 jerch

Tbh - I dont know, but lean somewhat more towards no support. Indeed the overhead is not as much as I thought in the beginning, also the code duplication of the PoC can be shortened alot by using some handler arguments.

But I am not sure yet whether the PoC already covers all aspects of the protected flag thingy, thus should be tested first by someone with an actual use case. Without any real world test case there is a high chance we get it partially wrong, or introduce more ugly reworks down the road. Thus my hesitation.

jerch avatar Mar 31 '22 16:03 jerch

@Tyriar I think I will give this another go, once the other PR #4095 is done. The needed changes seem so small so I dont see a reason not to support it. Still I dont quite grasp the full domain of those protection flags, so this needs some digging through old DEC manuals.

jerch avatar Sep 02 '22 20:09 jerch

@jerch sounds good, it's just one bit and we've got extended attributes working pretty well now

Tyriar avatar Sep 02 '22 21:09 Tyriar

Superseeded by #4098.

jerch avatar Sep 04 '22 11:09 jerch