xterm.js icon indicating copy to clipboard operation
xterm.js copied to clipboard

Published 20 hours ago • verified publisher icon xtermjs

emoji/unicode support mostly broken in windows

Open jerch opened this issue 5 years ago • 8 comments

Reminder issue to get the hands dirty to identify/fix unicode issues in windows, for some background see comments in https://github.com/xtermjs/xterm.js/pull/2568.

jerch avatar Feb 04 '20 20:02 jerch

Any plans to iterate on this issue?

ynechaev avatar Oct 29 '20 16:10 ynechaev

Just time is blocking it, I have too many more important things to look at so I doubt I would be able to get to it. This needs some investigation of what differs with emoji between native ptys and Conpty on Windows and to come up with a plan to support both.

Tyriar avatar Oct 29 '20 16:10 Tyriar

Emoji support for windows terminal looks backlogged since 2018 https://github.com/microsoft/terminal/issues/190

ynechaev avatar Oct 29 '20 16:10 ynechaev

Oh ok, so it's partially supported then. I thought I saw them advertising emoji support as one of the shiny things in WT 🤔

Tyriar avatar Oct 29 '20 16:10 Tyriar

Last time I looked at it the problem was around line/screen refresh pattern used by conpty. The emojis itself came thought but got partially scrambled by wrong offsets of the refreshs (deleting parts of multibyte chars).

jerch avatar Oct 29 '20 16:10 jerch

Some of the emoji still doesn't show up.

warengonzaga avatar Nov 21 '21 13:11 warengonzaga

still no hope... Vs code integrated bash terminal doesn't show all the emoji

  • echo emoji using .bash_profile does work but if we directly try to input emoji then it won't work image
  • Emoji shows up in external bash terminal image

ullaskunder3 avatar Mar 04 '22 16:03 ullaskunder3

Quick update here: Windows Terminal's emoji layout & handling has improved a lot over the last couple of years and now seems to handle most emoji that I throw at it pretty well. If you find specific emoji that don't render correctly in Windows Terminal, please find/file an issue at https://github.com/microsoft/terminal/issues

image

VSCode's terminal is a separate implementation built by @tyriar & team using JavaScript (since VSCode is an Electron-based app) and needs a little work to make emoji work better. As Daniel points out above, "this needs some investigation" so could be a good candidate for someone with some time available to dig in and see if improvements can be made?

bitcrazed avatar Mar 05 '22 21:03 bitcrazed

Hi, the issue i submitted to microsoft/vscode reports a bug in the pasting routine, and i've been redirected here. Briefly: If the text is pasted via right-click, it breaks up in multiple � characters. If the text is pasted via ctrl+v, it works correctly.

I just opened another issue in microsoft/terminal that might be related, i'm not sure: https://github.com/microsoft/terminal/issues/14084

aetonsi avatar Sep 26 '22 20:09 aetonsi