xterm.js icon indicating copy to clipboard operation
xterm.js copied to clipboard

Published 20 hours ago • verified publisher icon xtermjs

Add tests for CSI handlers

Open Tyriar opened this issue 5 years ago • 2 comments

  • [x] @
  • [x] A
  • [x] B
  • [x] C
  • [x] D
  • [x] E
  • [x] F
  • [x] G
  • [x] H
  • [x] I
  • [x] J
  • [ ] K
  • [x] L
  • [x] M
  • [x] P
  • [ ] S
  • [ ] T
  • [ ] X
  • [ ] Z
  • [ ] `
  • [ ] a
  • [x] b
  • [ ] c
  • [ ] d
  • [ ] e
  • [ ] f
  • [ ] g
  • [ ] h (some but incomplete)
  • [ ] l
  • [ ] m
  • [x] n
  • [ ] p
  • [ ] q
  • [ ] r
  • [ ] s
  • [ ] u

Tyriar avatar May 22 '19 05:05 Tyriar

@Tyriar Really nice to get those rolling now we have puppeteer. Once they reach a critical coverage, we can even get rid of the terminal tests with those ugly escape sequence test files.

Furthermore we still have many blind spots regarding correct sequence handling (xterm.js still fails badly in vttest for many tests) which can be fixed gradually with a strong test base.

jerch avatar May 24 '19 13:05 jerch

Yeah it feels good knowing that we won't break DSR again, that caused a bunch of random issues sitting in VS Code for a few days.

I like the escape sequence tests, just the way they're implemented feels a bit messy. Pretty sure many of the failures they exhibit are bugs/missing functionality from xterm.

Tyriar avatar May 24 '19 13:05 Tyriar