xsimd icon indicating copy to clipboard operation
xsimd copied to clipboard

error_gamma_test fails on macOS

Open sifmelcara opened this issue 2 years ago • 3 comments

Hello, I'm packaging xsimd 8.1.0 in Nix package manager (https://github.com/NixOS/nixpkgs/pull/187380), and our CI indicate that both M1 and Intel Mac has 1 test case failed (but they failed on different test case)

aarch64: link to CI log

[ RUN      ] error_gamma_test/arm_double.gamma
/tmp/nix-build-xsimd-8.1.0.drv-0/source/test/test_error_gamma.cpp:144: Failure
Expected equality of these values:
  diff
    Which is: 5
  0
  while testing lgamma (negative input)
[  FAILED  ] error_gamma_test/arm_double.gamma, where TypeParam = xsimd::batch<double, xsimd::neon64> (3 ms)

x86_64: link to CI log

[ RUN      ] error_gamma_test/fallback_double.gamma
/tmp/nix-build-xsimd-8.1.0.drv-0/source/test/test_error_gamma.cpp:144: Failure
Expected equality of these values:
  diff
    Which is: 3
  0
  while testing lgamma (negative input)
[  FAILED  ] error_gamma_test/fallback_double.gamma, where TypeParam = xsimd::batch<double, xsimd::sse4_1> (6 ms)

Do you have any idea? Thank you!

sifmelcara avatar Aug 23 '22 03:08 sifmelcara

Oh, I just noticed that previous person who packaged xsimd in our package manager already disabled "error_gamma_test/sse_double.gamma" test and "error_gamma_test/avx_double.gamma" test due to #456

Could this be a similar issue?

sifmelcara avatar Aug 23 '22 03:08 sifmelcara

Have there been any updates on this issue in xsimd 10/11?

SomeoneSerge avatar Apr 16 '23 16:04 SomeoneSerge

Hello Nixers. xsimd update to 11.1.0 happens in https://github.com/NixOS/nixpkgs/pull/246200 .

doronbehar avatar Jul 30 '23 16:07 doronbehar

I believe #1024 finally fixes it.

serge-sans-paille avatar May 19 '24 21:05 serge-sans-paille

I will fetch #1024 into nixpkgs, but I won't wait for CI this time. Thanks @serge-sans-paille for your help and communication.

doronbehar avatar May 21 '24 05:05 doronbehar