xsimd
xsimd copied to clipboard
batch_bool kernel `equal` method
We shoudl do two things:
- rename equal method to
eq
so that it matches the regular kernels - change the implementation in batch_bool_float kernel to use ! not_equal which is implemented in terms of xor
-
I think the methods name in the regular kernels match the specific part in the name of the intrinsics used for implementation. So if we rename
equal
intoeq
we should also rename all the other methods. I don't really see a benefit in doing this, what is important is thatbatch_bool_kernel<T, N>
implementations are consistent together, it does not really matter if they're not consistent with regular kernels. It's even easier for grepping ;) -
Yep, definitely!
I agree, functionality wise it won't make a difference -- I just thought it was weird that we have equal
vs eq
in batch_bool vs batch kernels, and not_equal
vs neq
. I still think renaming this function so that it matches would be slightly nicer.
Ok, but then let's rename other methods so they also match the intrinsics names!