slash-command-action icon indicating copy to clipboard operation
slash-command-action copied to clipboard

Stop failing the run and let the user decide how to proceed

Open xt0rted opened this issue 5 years ago • 2 comments
trafficstars

This was brought up in #124. The only time we should fail the run is when the user lacks the required permissions to trigger this step so this removes the calls to setFailed() and replaces them with debug().

To tell if this step was a success or not you can check the out params like so:

- run: echo "Runs only on /lint js command"
  if: steps.command.outputs.command-name && steps.command.outputs.command-arguments == 'js'

A subsequent PR will add a new has-command out parameter that's meant for these types of checks.

This is a breaking change for v1 so it'll be released as v2.

xt0rted avatar Feb 23 '20 04:02 xt0rted

Codecov Report

Merging #136 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   86.74%   86.74%           
=======================================
  Files           5        5           
  Lines          83       83           
  Branches       11       11           
=======================================
  Hits           72       72           
  Partials       11       11
Flag Coverage Δ
#unittests 86.74% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
src/commandHandler.ts 86.27% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a57d7f...c20683a. Read the comment docs.

codecov[bot] avatar Feb 23 '20 04:02 codecov[bot]

is this getting merged soon ?

dav009 avatar Mar 16 '20 00:03 dav009