GlobalQuake
GlobalQuake copied to clipboard
Adding Search Bar to Station Select UI
Work in progress of adding and implementing Search Bar into Select Station UI.
Closes issue #100
Hi again! I see there is some great work being done! I tested the search bar and for the first attempt, it looks promising! Of course there is still a lot of improvements to done and I will try to lead you what can be done in my comments.
I wanted to add a few notes:
- Upon updating the
countries.txt
, 2 nations had special characters which I added to the file. However, as seen by the commit previous, this caused a build error, specifically aError: Can't use 'tar -xzf' extract archive file
. This shouldn't be a big deal, but it's just something I noticed. - Just as a note, the code as marked in the first review that attempted to highlight the nation may cause the shape of the nation to appear in the search bar. This is not intended and should eventually be fixed when the highlight feature is added correctly. If you wish to see this, I especially noticed it clearly when I searched "India" in the search bar.
Also, I was wondering if you had any UI features for the search bar that you wish to implement. If so, please provide an example as well as an image if possible so I can try to recreate it as best I can :)
Hi!
Sorry that I haven't looked at your PR in the past few days, I was pretty busy with all the other stuff and also the search bar feature feels pretty difficult to implement in a nice way for me at this moment and I didn't know how to help. Also, I knew I would be changing the polygon files in the near future that contain the country names and later I added more region borders. The new polygons could also be used for the search bar. Actually, you won't probably need the search suggestions.txt file, but you can create the list from already loaded polygons in Regions.java. There is for example regionsHD
list, that contains all countries together with the polygons that you can use to fetch the coordinates that the globe would then zoom into using my new smoothTransition
API.
Tell me what you think :) You can maybe have a look inside the Regions.java file to see how I handle the polygons, but overall this feature will require quite lot of work and I have dozens of other features that are requested by many people every day :D
Please let me know when is a good time to resume work on this PR :)
I sure will :) Not yet though as we want to add more regions soon that can be used for the search bar, and I'm pretty busy with university. Also there is absolutely nothing wrong about if you try to implement some other smaller feature in the meantime :)